[PATCH] D51459: [WebAssembly][WIP] Vector conversions

[Wouter van Oortmerssen via Phabricator via llvm-commits]

aardappel added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyRegStackify.cpp:569
+  if (WasmDisableExplicitLocals)
+    return Def;
+
----------------
aheejin wrote:
> tlively wrote:
> > @aardappel This solution for the problem described in the comment fixes my own test, but causes crashes in the stackification tests. I assume this function is doing other work besides creating a TEE that cannot be skipped. Could you suggest a more robust way to fix this problem?
> (We talked in person and I'm gonna summarize it here)
> Giving those instructions fake opcodes (like 0) can be one solution too.
Yes, we'd really want to avoid checks like this, as disabling the explicit locals is something pretty hacky we only do to keep current tests happy.

I think the easiest solution is to convert the affected test to work with explicit locals?


Repository:
  rL LLVM

https://reviews.llvm.org/D51459