[PATCH] D48792: [ARM] Set execute-only flags in .text.

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 30 05:40:27 PDT 2018


peter.smith added a comment.

Thanks for the update. I still think this looks good to me.

I'm out of quick ideas for how to do this in a better way. The only other ways that I can think of are to not pre-create the .text section and create in on demand if needed; or find some way of deleting it afterwards. These may be possible but will be more disruptive. I think that this will handle the LTO case where the "link-step" clang invocation doesn't get passed the -fexecute-only flag, which IIRC was the main reason not to just create the TextSection with the execute-only flag in the first place based on the presence of -fexecute-only.


https://reviews.llvm.org/D48792





More information about the llvm-commits mailing list