[llvm] r341000 - [MS Demangler] Fix several crashes and demangling bugs.

Friedman, Eli via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 29 17:23:23 PDT 2018


On 8/29/2018 4:56 PM, Zachary Turner via llvm-commits wrote:
>    * Account for "incorrect" string literal demanglings.  Apparently
>      an older version of clang would not truncate mangled string
>      literals to 32 bytes of encoded character data.  The demangling
>      code however would allocate a 32 byte buffer thinking that it
>      would not encounter more than this, and overrun the buffer.
>      We now demangle up to 128 bytes of data, since the buggy
>      clang would encode up to 32 *characters* of data.

It sounds like this was this a crash?  If so, did you fix the crash?

-Eli

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project



More information about the llvm-commits mailing list