[PATCH] D51459: [WebAssembly][WIP] Vector conversions

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 29 14:32:29 PDT 2018


tlively added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyRegStackify.cpp:569
+  if (WasmDisableExplicitLocals)
+    return Def;
+
----------------
@aardappel This solution for the problem described in the comment fixes my own test, but causes crashes in the stackification tests. I assume this function is doing other work besides creating a TEE that cannot be skipped. Could you suggest a more robust way to fix this problem?


Repository:
  rL LLVM

https://reviews.llvm.org/D51459





More information about the llvm-commits mailing list