[PATCH] D51430: [llvm-mca] Report the number of dispatched micro opcodes in the DispatchStatistics view.

[Matt Davis via Phabricator via llvm-commits]

mattd accepted this revision.
mattd added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: tools/llvm-mca/Views/DispatchStatistics.cpp:69
+  SS << "\n\nDynamic Dispatch Stall Cycles:\n";
+  SS << "RAT     - Register unavailable:                      ";
+  printStalls(SS, HWStalls[HWStallEvent::RegisterFileStall], NumCycles);
----------------
It looks like this line is missing a single space, to put it inline with the rest of the output below.


================
Comment at: tools/llvm-mca/Views/TimelineView.h:129
   struct TimelineViewEntry {
-    unsigned CycleDispatched;
+    int CycleDispatched;  // A negative value is an "invalid cycle".
     unsigned CycleReady;
----------------
This makes sense, but just for the sake of mentioning it.  If we did make all of the other counters signed, then all counters would be uniform (in signedness) and we would not need to do any casting when comparing CycleDispatched against the other counters. 


https://reviews.llvm.org/D51430