[PATCH] D51255: [WWW] Use https instead of http to fix page problems

Mike Edwards via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 29 10:28:53 PDT 2018


sqlbyme added a comment.

First off, thanks for offering to help make the website work correctly!  This all looks pretty reasonable to me.  I'm wondering though, would it be possible to break this patch up into a few smaller patches?  Since we do not have any type of staging infrastructure for llvm.org, I would prefer we not change so many files all at once.  I feel like three steps here might be appropriate:

1. Try with one file (one of the files with a one or two line change) to ensure the changes work as we expect them to.
2. Apply changes to the rest of the files with the exception of footer.incl.
3. Apply the last patch to footer.incl which adds the javascript bits in the footer (my experience tells me this is the most likely to break something, though the JS you have provided LGTM).

Thanks,
Mike


https://reviews.llvm.org/D51255





More information about the llvm-commits mailing list