[llvm] r340925 - Revert r340922 "[GVNHoist] Re-enable GVNHoist by default"
Hans Wennborg via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 29 06:40:04 PDT 2018
Thanks for reverting, I believe it also broke Chromium's Clang
bootstrap, see https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8936856384105590032/+/steps/package_clang/0/stdout
On Wed, Aug 29, 2018 at 3:00 PM, Alexandros Lamprineas via
llvm-commits <llvm-commits at lists.llvm.org> wrote:
> Author: alelab01
> Date: Wed Aug 29 06:00:55 2018
> New Revision: 340925
>
> URL: http://llvm.org/viewvc/llvm-project?rev=340925&view=rev
> Log:
> Revert r340922 "[GVNHoist] Re-enable GVNHoist by default"
>
> Another sanitizer buildbot failed this time at bootstrap when
> compiling SemaTemplateInstantiate.cpp with this assertion:
> `dominates(MD, U) && "Memory Def does not dominate it's uses"'.
>
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/15047
>
> Modified:
> llvm/trunk/lib/Passes/PassBuilder.cpp
> llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp
> llvm/trunk/test/Other/new-pm-defaults.ll
> llvm/trunk/test/Other/new-pm-thinlto-defaults.ll
> llvm/trunk/test/Other/opt-O2-pipeline.ll
> llvm/trunk/test/Other/opt-O3-pipeline.ll
> llvm/trunk/test/Other/opt-Os-pipeline.ll
>
> Modified: llvm/trunk/lib/Passes/PassBuilder.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Passes/PassBuilder.cpp?rev=340925&r1=340924&r2=340925&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Passes/PassBuilder.cpp (original)
> +++ llvm/trunk/lib/Passes/PassBuilder.cpp Wed Aug 29 06:00:55 2018
> @@ -174,8 +174,8 @@ static cl::opt<bool> EnableEarlyCSEMemSS
> cl::desc("Enable the EarlyCSE w/ MemorySSA pass for the new PM (default = on)"));
>
> static cl::opt<bool> EnableGVNHoist(
> - "enable-npm-gvn-hoist", cl::init(true), cl::Hidden,
> - cl::desc("Enable the GVN hoisting pass for the new PM (default = on)"));
> + "enable-npm-gvn-hoist", cl::init(false), cl::Hidden,
> + cl::desc("Enable the GVN hoisting pass for the new PM (default = off)"));
>
> static cl::opt<bool> EnableGVNSink(
> "enable-npm-gvn-sink", cl::init(false), cl::Hidden,
>
> Modified: llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp?rev=340925&r1=340924&r2=340925&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp (original)
> +++ llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp Wed Aug 29 06:00:55 2018
> @@ -135,8 +135,8 @@ static cl::opt<bool> EnableEarlyCSEMemSS
> cl::desc("Enable the EarlyCSE w/ MemorySSA pass (default = on)"));
>
> static cl::opt<bool> EnableGVNHoist(
> - "enable-gvn-hoist", cl::init(true), cl::Hidden,
> - cl::desc("Enable the GVN hoisting pass (default = on)"));
> + "enable-gvn-hoist", cl::init(false), cl::Hidden,
> + cl::desc("Enable the GVN hoisting pass (default = off)"));
>
> static cl::opt<bool>
> DisableLibCallsShrinkWrap("disable-libcalls-shrinkwrap", cl::init(false),
>
> Modified: llvm/trunk/test/Other/new-pm-defaults.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Other/new-pm-defaults.ll?rev=340925&r1=340924&r2=340925&view=diff
> ==============================================================================
> --- llvm/trunk/test/Other/new-pm-defaults.ll (original)
> +++ llvm/trunk/test/Other/new-pm-defaults.ll Wed Aug 29 06:00:55 2018
> @@ -121,10 +121,6 @@
> ; CHECK-O-NEXT: Running pass: SROA
> ; CHECK-O-NEXT: Running pass: EarlyCSEPass
> ; CHECK-O-NEXT: Running analysis: MemorySSAAnalysis
> -; CHECK-O-NEXT: Running pass: GVNHoistPass on foo
> -; CHECK-O-NEXT: Running analysis: PostDominatorTreeAnalysis on foo
> -; CHECK-O-NEXT: Running analysis: MemoryDependenceAnalysis on foo
> -; CHECK-O-NEXT: Running analysis: PhiValuesAnalysis on foo
> ; CHECK-O-NEXT: Running pass: SpeculativeExecutionPass
> ; CHECK-O-NEXT: Running pass: JumpThreadingPass
> ; CHECK-O-NEXT: Running analysis: LazyValueAnalysis
> @@ -173,13 +169,23 @@
> ; CHECK-O-NEXT: Finished Loop pass manager run.
> ; CHECK-Os-NEXT: Running pass: MergedLoadStoreMotionPass
> ; CHECK-Os-NEXT: Running pass: GVN
> +; CHECK-Os-NEXT: Running analysis: MemoryDependenceAnalysis
> +; CHECK-Os-NEXT: Running analysis: PhiValuesAnalysis
> ; CHECK-Oz-NEXT: Running pass: MergedLoadStoreMotionPass
> ; CHECK-Oz-NEXT: Running pass: GVN
> +; CHECK-Oz-NEXT: Running analysis: MemoryDependenceAnalysis
> +; CHECK-Oz-NEXT: Running analysis: PhiValuesAnalysis
> ; CHECK-O2-NEXT: Running pass: MergedLoadStoreMotionPass
> ; CHECK-O2-NEXT: Running pass: GVN
> +; CHECK-O2-NEXT: Running analysis: MemoryDependenceAnalysis
> +; CHECK-O2-NEXT: Running analysis: PhiValuesAnalysis
> ; CHECK-O3-NEXT: Running pass: MergedLoadStoreMotionPass
> ; CHECK-O3-NEXT: Running pass: GVN
> +; CHECK-O3-NEXT: Running analysis: MemoryDependenceAnalysis
> +; CHECK-O3-NEXT: Running analysis: PhiValuesAnalysis
> ; CHECK-O-NEXT: Running pass: MemCpyOptPass
> +; CHECK-O1-NEXT: Running analysis: MemoryDependenceAnalysis
> +; CHECK-O1-NEXT: Running analysis: PhiValuesAnalysis
> ; CHECK-O-NEXT: Running pass: SCCPPass
> ; CHECK-O-NEXT: Running pass: BDCEPass
> ; CHECK-O-NEXT: Running analysis: DemandedBitsAnalysis
> @@ -195,6 +201,7 @@
> ; CHECK-O-NEXT: Finished llvm::Function pass manager run.
> ; CHECK-EP-SCALAR-LATE-NEXT: Running pass: NoOpFunctionPass
> ; CHECK-O-NEXT: Running pass: ADCEPass
> +; CHECK-O-NEXT: Running analysis: PostDominatorTreeAnalysis
> ; CHECK-O-NEXT: Running pass: SimplifyCFGPass
> ; CHECK-O-NEXT: Running pass: InstCombinePass
> ; CHECK-EP-PEEPHOLE-NEXT: Running pass: NoOpFunctionPass
>
> Modified: llvm/trunk/test/Other/new-pm-thinlto-defaults.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Other/new-pm-thinlto-defaults.ll?rev=340925&r1=340924&r2=340925&view=diff
> ==============================================================================
> --- llvm/trunk/test/Other/new-pm-thinlto-defaults.ll (original)
> +++ llvm/trunk/test/Other/new-pm-thinlto-defaults.ll Wed Aug 29 06:00:55 2018
> @@ -106,10 +106,6 @@
> ; CHECK-O-NEXT: Running pass: SROA
> ; CHECK-O-NEXT: Running pass: EarlyCSEPass
> ; CHECK-O-NEXT: Running analysis: MemorySSAAnalysis
> -; CHECK-O-NEXT: Running pass: GVNHoistPass on foo
> -; CHECK-O-NEXT: Running analysis: PostDominatorTreeAnalysis on foo
> -; CHECK-O-NEXT: Running analysis: MemoryDependenceAnalysis on foo
> -; CHECK-O-NEXT: Running analysis: PhiValuesAnalysis on foo
> ; CHECK-O-NEXT: Running pass: SpeculativeExecutionPass
> ; CHECK-O-NEXT: Running pass: JumpThreadingPass
> ; CHECK-O-NEXT: Running analysis: LazyValueAnalysis
> @@ -155,13 +151,23 @@
> ; CHECK-O-NEXT: Finished Loop pass manager run.
> ; CHECK-Os-NEXT: Running pass: MergedLoadStoreMotionPass
> ; CHECK-Os-NEXT: Running pass: GVN
> +; CHECK-Os-NEXT: Running analysis: MemoryDependenceAnalysis
> +; CHECK-Os-NEXT: Running analysis: PhiValuesAnalysis
> ; CHECK-Oz-NEXT: Running pass: MergedLoadStoreMotionPass
> ; CHECK-Oz-NEXT: Running pass: GVN
> +; CHECK-Oz-NEXT: Running analysis: MemoryDependenceAnalysis
> +; CHECK-Oz-NEXT: Running analysis: PhiValuesAnalysis
> ; CHECK-O2-NEXT: Running pass: MergedLoadStoreMotionPass
> ; CHECK-O2-NEXT: Running pass: GVN
> +; CHECK-O2-NEXT: Running analysis: MemoryDependenceAnalysis
> +; CHECK-O2-NEXT: Running analysis: PhiValuesAnalysis
> ; CHECK-O3-NEXT: Running pass: MergedLoadStoreMotionPass
> ; CHECK-O3-NEXT: Running pass: GVN
> +; CHECK-O3-NEXT: Running analysis: MemoryDependenceAnalysis
> +; CHECK-O3-NEXT: Running analysis: PhiValuesAnalysis
> ; CHECK-O-NEXT: Running pass: MemCpyOptPass
> +; CHECK-O1-NEXT: Running analysis: MemoryDependenceAnalysis
> +; CHECK-O1-NEXT: Running analysis: PhiValuesAnalysis
> ; CHECK-O-NEXT: Running pass: SCCPPass
> ; CHECK-O-NEXT: Running pass: BDCEPass
> ; CHECK-O-NEXT: Running analysis: DemandedBitsAnalysis
> @@ -175,6 +181,7 @@
> ; CHECK-O-NEXT: Running pass: LCSSAPass
> ; CHECK-O-NEXT: Finished llvm::Function pass manager run
> ; CHECK-O-NEXT: Running pass: ADCEPass
> +; CHECK-O-NEXT: Running analysis: PostDominatorTreeAnalysis
> ; CHECK-O-NEXT: Running pass: SimplifyCFGPass
> ; CHECK-O-NEXT: Running pass: InstCombinePass
> ; CHECK-O-NEXT: Finished llvm::Function pass manager run.
>
> Modified: llvm/trunk/test/Other/opt-O2-pipeline.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Other/opt-O2-pipeline.ll?rev=340925&r1=340924&r2=340925&view=diff
> ==============================================================================
> --- llvm/trunk/test/Other/opt-O2-pipeline.ll (original)
> +++ llvm/trunk/test/Other/opt-O2-pipeline.ll Wed Aug 29 06:00:55 2018
> @@ -59,12 +59,6 @@
> ; CHECK-NEXT: Function Alias Analysis Results
> ; CHECK-NEXT: Memory SSA
> ; CHECK-NEXT: Early CSE w/ MemorySSA
> -; CHECK-NEXT: Post-Dominator Tree Construction
> -; CHECK-NEXT: Basic Alias Analysis (stateless AA impl)
> -; CHECK-NEXT: Function Alias Analysis Results
> -; CHECK-NEXT: Phi Values Analysis
> -; CHECK-NEXT: Memory Dependence Analysis
> -; CHECK-NEXT: Early GVN Hoisting of Expressions
> ; CHECK-NEXT: Speculatively execute instructions if target has divergent branches
> ; CHECK-NEXT: Basic Alias Analysis (stateless AA impl)
> ; CHECK-NEXT: Function Alias Analysis Results
>
> Modified: llvm/trunk/test/Other/opt-O3-pipeline.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Other/opt-O3-pipeline.ll?rev=340925&r1=340924&r2=340925&view=diff
> ==============================================================================
> --- llvm/trunk/test/Other/opt-O3-pipeline.ll (original)
> +++ llvm/trunk/test/Other/opt-O3-pipeline.ll Wed Aug 29 06:00:55 2018
> @@ -62,12 +62,6 @@
> ; CHECK-NEXT: Function Alias Analysis Results
> ; CHECK-NEXT: Memory SSA
> ; CHECK-NEXT: Early CSE w/ MemorySSA
> -; CHECK-NEXT: Post-Dominator Tree Construction
> -; CHECK-NEXT: Basic Alias Analysis (stateless AA impl)
> -; CHECK-NEXT: Function Alias Analysis Results
> -; CHECK-NEXT: Phi Values Analysis
> -; CHECK-NEXT: Memory Dependence Analysis
> -; CHECK-NEXT: Early GVN Hoisting of Expressions
> ; CHECK-NEXT: Speculatively execute instructions if target has divergent branches
> ; CHECK-NEXT: Basic Alias Analysis (stateless AA impl)
> ; CHECK-NEXT: Function Alias Analysis Results
>
> Modified: llvm/trunk/test/Other/opt-Os-pipeline.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Other/opt-Os-pipeline.ll?rev=340925&r1=340924&r2=340925&view=diff
> ==============================================================================
> --- llvm/trunk/test/Other/opt-Os-pipeline.ll (original)
> +++ llvm/trunk/test/Other/opt-Os-pipeline.ll Wed Aug 29 06:00:55 2018
> @@ -59,12 +59,6 @@
> ; CHECK-NEXT: Function Alias Analysis Results
> ; CHECK-NEXT: Memory SSA
> ; CHECK-NEXT: Early CSE w/ MemorySSA
> -; CHECK-NEXT: Post-Dominator Tree Construction
> -; CHECK-NEXT: Basic Alias Analysis (stateless AA impl)
> -; CHECK-NEXT: Function Alias Analysis Results
> -; CHECK-NEXT: Phi Values Analysis
> -; CHECK-NEXT: Memory Dependence Analysis
> -; CHECK-NEXT: Early GVN Hoisting of Expressions
> ; CHECK-NEXT: Speculatively execute instructions if target has divergent branches
> ; CHECK-NEXT: Basic Alias Analysis (stateless AA impl)
> ; CHECK-NEXT: Function Alias Analysis Results
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
More information about the llvm-commits
mailing list