[PATCH] D51400: Always add a .note.GNU-stack section if -r.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 28 20:48:39 PDT 2018


ruiu created this revision.
ruiu added a reviewer: rprichard.
Herald added subscribers: arichardson, emaste.
Herald added a reviewer: espindola.

With this patch, lld creates a .note.GNU_stack and adds it to an
output file if it is creating a re-linkable object file (i.e. if -r
is given). If we don't do this, and if you use GNU linkers as a final
linker, they create an executable whose stack area is executable,
which is considered pretty bad these days.


https://reviews.llvm.org/D51400

Files:
  lld/ELF/SyntheticSections.h
  lld/ELF/Writer.cpp
  lld/test/ELF/relocatable-bss.s
  lld/test/ELF/relocatable-comdat-multiple.s
  lld/test/ELF/relocatable-comdat.s
  lld/test/ELF/relocatable-comdat2.s
  lld/test/ELF/relocatable-many-sections.s
  lld/test/ELF/relocatable.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51400.163008.patch
Type: text/x-patch
Size: 7625 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180829/977b101f/attachment.bin>


More information about the llvm-commits mailing list