[PATCH] D51383: [WebAssembly] SIMD loads and stores

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:264
+def : StorePatGlobalAddrOffOnly<vec_t, store, !cast<NI>("STORE_"#vec_t)>;
+def : StorePatExternSymOffOnly<vec_t, store, !cast<NI>("STORE_"#vec_t)>;
+
----------------
Do we have tests for these load/store offset patterns? Tests for scalars are [[ https://github.com/llvm-mirror/llvm/blob/master/test/CodeGen/WebAssembly/offset.ll | here ]], and I think we need similar variation of tests for SIMDs too. We probably wouldn't need all of offset variation tests for all existing vector types though. Maybe offset tests for one SIMD type would be sufficient.


Repository:
  rL LLVM

https://reviews.llvm.org/D51383