[PATCH] D51327: [MemorySSA] Add expesive check for validating clobber accesses.

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 28 14:54:26 PDT 2018


asbirlea marked an inline comment as done.
asbirlea added inline comments.


================
Comment at: lib/Analysis/MemorySSA.cpp:1705
+    UpwardsMemoryQuery Q(I, MUD);
+    checkClobberSanity(const_cast<MemoryUseOrDef *>(MUD), Clobber, *Loc, *this, Q, *AA);
+  }
----------------
Nit: keep the `const` up until `upward_defs_begin` and const_cast there?
(Worklist can be ConstMemoryAccessPair).
This seemed cleaner, but I'm ok with it either way.


Repository:
  rL LLVM

https://reviews.llvm.org/D51327





More information about the llvm-commits mailing list