[PATCH] D51089: [LLD] [COFF] Add support for creating range extension thunks for ARM

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: COFF/Chunks.cpp:663
+    0xc0, 0xf2, 0x00, 0x0c, //     movt ip,:upper16:S - (P + (L1-P) + 4)
+    0xfc, 0x44,             // L1: add  ip, pc
+    0x60, 0x47,             //     bx   ip
----------------
efriedma wrote:
> Can you use "add pc, ip" instead?  That's not an interworking branch, but I think we can assume the target is Thumb mode here.
Oh, indeed, that'll make it as small as the other ones, while being PIC. Will update.


https://reviews.llvm.org/D51089