[PATCH] D51375: [SimpleLoopUnswitch] Form dedicated exits after trivial unswitches.

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 28 13:27:04 PDT 2018


fedor.sergeev accepted this revision.
fedor.sergeev added a comment.
This revision is now accepted and ready to land.

source changes LGTM.
comments and suggested test change - up to your discretion.



================
Comment at: lib/Transforms/Scalar/SimpleLoopUnswitch.cpp:308
+    // here is the (just split by unswitching) preheader. However, after trivial
+    // switches, we may have non-dedicated exits, so let's conservatively
+    // form dedicated exit blocks and figure out if we can optimize later.
----------------
instead of "trivial switches" I would say something like:

"after trivial unswitching it is possible to get new non-dedicated exits out of parent loop"



Repository:
  rL LLVM

https://reviews.llvm.org/D51375





More information about the llvm-commits mailing list