[PATCH] D48179: [AMDGPU] Emit MessagePack HSA Metadata for v3 code object

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 28 12:45:20 PDT 2018


scott.linder updated this revision to Diff 162933.
scott.linder added a comment.
Herald added a subscriber: jvesely.

Address feedback. There was no particular reason for not writing these inline, other than to prevent typos. With the verifier and tests we have I don't think that is an issue, and I agree these being grepable is worthwhile.


https://reviews.llvm.org/D48179

Files:
  include/llvm/BinaryFormat/AMDGPUMetadataVerifier.h
  include/llvm/BinaryFormat/ELF.h
  include/llvm/Support/AMDGPUMetadata.h
  lib/BinaryFormat/AMDGPUMetadataVerifier.cpp
  lib/BinaryFormat/CMakeLists.txt
  lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
  lib/Target/AMDGPU/AMDGPUAsmPrinter.h
  lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp
  lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.h
  lib/Target/AMDGPU/AMDGPUPTNote.h
  lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp
  lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.h
  test/CodeGen/AMDGPU/attr-amdgpu-flat-work-group-size-v3.ll
  test/CodeGen/AMDGPU/code-object-v3.ll
  test/CodeGen/AMDGPU/hsa-metadata-deduce-ro-arg-v3.ll
  test/CodeGen/AMDGPU/hsa-metadata-enqueu-kernel-v3.ll
  test/CodeGen/AMDGPU/hsa-metadata-from-llvm-ir-full-v3.ll
  test/CodeGen/AMDGPU/hsa-metadata-hidden-args-v3.ll
  test/CodeGen/AMDGPU/hsa-metadata-images-v3.ll
  test/CodeGen/AMDGPU/hsa-metadata-invalid-ocl-version-1-v3.ll
  test/CodeGen/AMDGPU/hsa-metadata-invalid-ocl-version-2-v3.ll
  test/CodeGen/AMDGPU/hsa-metadata-invalid-ocl-version-3-v3.ll
  test/CodeGen/AMDGPU/hsa-metadata-kernel-code-props-v3.ll
  test/MC/AMDGPU/hsa-metadata-kernel-args-v3.s
  test/MC/AMDGPU/hsa-metadata-kernel-attrs-v3.s
  test/MC/AMDGPU/hsa-metadata-kernel-code-props-v3.s
  test/MC/AMDGPU/hsa-v3.s
  tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48179.162933.patch
Type: text/x-patch
Size: 175013 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180828/c27ac61c/attachment-0001.bin>


More information about the llvm-commits mailing list