[PATCH] D51276: [New PM][PassTiming] implement -time-passes for the new pass manager

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: lib/Analysis/CGSCCPassManager.cpp:80-81
 
+    if (MyTimer && MyTimer->isRunning())
+      MyTimer->stopTimer();
+
----------------
This shows up 4 times in the patch. Seems like a good candidate for a utility function. Something like `stopTimerIfRunning`, perhaps?


================
Comment at: lib/Analysis/CGSCCPassManager.cpp:85
 
+    if (MyTimer && MyTimer->hasTriggered() && !MyTimer->isRunning())
+      MyTimer->startTimer();
----------------
Ditto here. Something like `startTimerIfTriggered`?


Repository:
  rL LLVM

https://reviews.llvm.org/D51276