[PATCH] D50940: [sanitizer] Change Mmap*NoAccess to return nullptr on error

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 28 08:24:25 PDT 2018


cryptoad added a comment.

Link to test source: https://github.com/llvm-mirror/compiler-rt/blob/master/test/msan/mmap.cc#L78
Last test output: 0xf00000000
Link to msan mmap interceptor: https://github.com/llvm-mirror/compiler-rt/blob/master/lib/msan/msan_interceptors.cc#L939

As far as I understand, this test is failing because 0xf00000000 is not within the allowed AddrMapping for aarch64.
I am not sure how those mappings where added to the list in the first place.
Looking at mmap_interceptor for msan, I don't think the patch impacts it at all (it just calls real_mmap)

I'll setting up an aarch64 environment, I'll try and add the new mapping(s) and see how it fairs (unless someone can beat me to it - I only have a BBB for AArch64 so it's going to take a while)


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D50940





More information about the llvm-commits mailing list