[PATCH] D44897: [PowerPC] Do not emit record-form rotates when record-form andi/andis suffices

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 28 06:36:57 PDT 2018


nemanjai marked an inline comment as done.
nemanjai added inline comments.


================
Comment at: lib/Target/PowerPC/PPCInstrInfo.cpp:1803
+  if (MIOpC == PPC::ANDIo || MIOpC == PPC::ANDIo8 ||
+      MIOpC == PPC::ANDISo || MIOpC == PPC::ANDISo8)
     NewOpC = MIOpC;
----------------
inouehrs wrote:
> This change seems independent from other part of this patch. So this can be a separate patch.
> Also it is nice to add an unit test for this part. 
> 
Both great points (this part being orthogonal as well as needing its own test case). Separate patch in https://reviews.llvm.org/D51353


Repository:
  rL LLVM

https://reviews.llvm.org/D44897





More information about the llvm-commits mailing list