[PATCH] D51197: [GISel]: Add missing opcodes for overflow intrinsics

Igor Breger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 28 03:07:55 PDT 2018


igorb added a comment.

In https://reviews.llvm.org/D51197#1215499, @aemerson wrote:

> x86 is still using UADDE, and it's generated only by IRTranslator, so if you do this then x86 will lose support for compiling llvm.uadd.with.overflow intrinsics. @igorb what do you think?
>
> Which is exposing a hole in our general GISel testing, where individual changes in passes can result in overall support for some input IR to be lost.


Hi,
I think currently X86 use G_UADDE  generated by Legalizer  to support 64bit add on 32bit architecture.

Regards,
Igor


Repository:
  rL LLVM

https://reviews.llvm.org/D51197





More information about the llvm-commits mailing list