[PATCH] D44897: [PowerPC] Do not emit record-form rotates when record-form andi/andis suffices

Hiroshi Inoue via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 28 00:12:06 PDT 2018


inouehrs added a comment.

> This patch increases the number of record-form rotates we emit by more than 70%.

Do you mean reducing the record-form rotates by 70%? If so, it is great!



================
Comment at: lib/Target/PowerPC/PPCInstrInfo.cpp:1803
+  if (MIOpC == PPC::ANDIo || MIOpC == PPC::ANDIo8 ||
+      MIOpC == PPC::ANDISo || MIOpC == PPC::ANDISo8)
     NewOpC = MIOpC;
----------------
This change seems independent from other part of this patch. So this can be a separate patch.
Also it is nice to add an unit test for this part. 



Repository:
  rL LLVM

https://reviews.llvm.org/D44897





More information about the llvm-commits mailing list