[PATCH] D51313: [LV] Fix code gen for conditionally executed uniform loads

Hideki Saito via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 27 23:27:07 PDT 2018


hsaito added a comment.

In https://reviews.llvm.org/D51313#1214979, @hsaito wrote:

> > This affects architectures that have masked gather/scatter support.
>
> I moved that check from legal to cost model (https://reviews.llvm.org/D43208). As a result, the same issue should happen for arch w/o masked gather/scatter support, probably less often. If you can make the LIT test generic (i.e., not x86 specific), that would be better (but not a must-fix).


Taking this back. The trigger requires "isLegalMask*()" returning true.


Repository:
  rL LLVM

https://reviews.llvm.org/D51313





More information about the llvm-commits mailing list