[PATCH] D50931: Consider isLegalAddressingImm in Constant Hoisting

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/Transforms/Scalar/ConstantHoisting.cpp:598
+            MemUseValTy = SI->getValueOperand()->getType();
+          break;
+        }
----------------
The break should be inside the if statement, I think?

I guess more broadly, it's not clear what we should do if there are mixed address and non-address uses... but the current behavior is reasonable.


Repository:
  rL LLVM

https://reviews.llvm.org/D50931