[PATCH] D51313: [LV] Fix code gen for conditionally executed uniform loads

[Hideki Saito via Phabricator via llvm-commits]

hsaito added a comment.

> This affects architectures that have masked gather/scatter support.

I moved that check from legal to cost model (https://reviews.llvm.org/D43208). As a result, the same issue should happen for arch w/o masked gather/scatter support, probably less often. If you can make the LIT test generic (i.e., not x86 specific), that would be better (but not a must-fix).

We should introduce something like CM_PredicatedUniform and then generate code as "if (mask is not all zero){ load and bcast }" (and that should make the FileCheck validation much simpler), but stop bleeding first approach is fine.

Nice small fix. LGTM.


Repository:
  rL LLVM

https://reviews.llvm.org/D51313