[PATCH] D49678: [llvm-objcopy] Adding support for compressed DWARF debug sections.

[Puyan Lotfi via Phabricator via llvm-commits]

plotfi marked 3 inline comments as done.
plotfi added inline comments.


================
Comment at: tools/llvm-objcopy/Object.h:336
+protected:
+  std::string OwnedName;
   std::vector<uint8_t> Data;
----------------
jakehehrlich wrote:
> plotfi wrote:
> > jakehehrlich wrote:
> > > plotfi wrote:
> > > > jakehehrlich wrote:
> > > > > So it turns out that we want to make names std::string instead of StringRefs anyway so this is no longer needed. (two other changes also needed this). That will likely be landing soon.
> > > > ETA?
> > > I think that's happening in this change: https://reviews.llvm.org/D50463
> > > 
> > > I think Paul is finished with GSoC so it's up to Paul. You can go ahead and use code from that change in this change so that the rebase will be minimal.
> > As far as I can tell, this is not comitted yet. Should I wait for this to land or take it from the diferential you sent?
> Given that Paul hasn't worked out that and how close this patch is to getting an LGTM from me I think you should be the one to make that change in this patch.
I took a look at this patch (D50463). As far as I can tell the one addition is the StartsWith method. I am not sure we need it here unless you have a big preference to add it.


Repository:
  rL LLVM

https://reviews.llvm.org/D49678