[PATCH] D51248: Support for remapping profile data, for sample-based profiling.

[Wei Mi via Phabricator via llvm-commits]

wmi added a comment.

> We do not support remapping indirect branch target information, but all other profile data should be remapped appropriately.

Any particular reason for that? Without support of call target, the performance could still be hurt badly after the renaming.



================
Comment at: lib/ProfileData/SampleProfReader.cpp:833
+  // we don't know what the original function names were.
+  if (getFormat() == SPF_Compact_Binary) {
+    Ctx.diagnose(DiagnosticInfoSampleProfile(
----------------
davidxl wrote:
> Ideally, there should be a tool to convert the compact format file into a non-compact file. The nocompat file is then fed into the profile remapping tool which converts the profile to the remapped namespace.
Most of the time, we can regenerate the non-compact profile and use the remapping tool to convert the non-compact profile directly. Currently I don't see I have the need to convert non-compact profile directly. We may leave the request there for the moment until we need it.  


Repository:
  rL LLVM

https://reviews.llvm.org/D51248