[PATCH] D51237: DAG: Check transformed type for forming fminnum/fmaxnum from vselect

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 27 10:59:23 PDT 2018


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:7052
 
+  EVT LegalVT = TLI.getTypeToTransformTo(*DAG.getContext(), VT);
   switch (CC) {
----------------
nhaehnle wrote:
> Maybe rename to TargetVT or TransformedVT? After all, this VT isn't necessarily legal...
I think it is?


https://reviews.llvm.org/D51237





More information about the llvm-commits mailing list