[PATCH] D51081: [DWARF v5] Refactoring range list dumping to fold DWARF v4 functionality into v5 handling (almost NFC).

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFDebugRnglists.cpp:86
+        return createStringError(
+            errc::invalid_argument,
+            "invalid range list entry at offset 0x%" PRIx32, *OffsetPtr);
----------------
vleschuk wrote:
> vleschuk wrote:
> > Maybe illegal_byte_sequence would be more suitable here?
> Why is this marked as done?
It's because the relevant code was moved to the RLE_offset_pair clause. I made the change there Sorry I should have pointed this out.


https://reviews.llvm.org/D51081