[PATCH] D50629: AMDGPU: Fix getInstSizeInBytes

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 27 09:05:28 PDT 2018


arsenm added a comment.

In https://reviews.llvm.org/D50629#1210582, @nhaehnle wrote:

> In https://reviews.llvm.org/D50629#1209494, @arsenm wrote:
>
> > In https://reviews.llvm.org/D50629#1209249, @nhaehnle wrote:
> >
> > > Always do the sanity check in debug builds.
> > >
> > > I was originally worried about how expensive this is, but it
> > >  doesn't show up in the running time of all the tests in
> > >  test/CodeGen/AMDGPU.
> >
> >
> > These are by design almost all small, so that makes sense. It might not be representative in the real world
>
>
> We shouldn't be running debug builds in the real world anyway.


This will run with fast debug builds, which is what I usually use


Repository:
  rL LLVM

https://reviews.llvm.org/D50629





More information about the llvm-commits mailing list