[PATCH] D51255: [WWW] Use https instead of http to fix page problems

Kevin P. Neal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 27 07:32:23 PDT 2018


kpn added a comment.

In https://reviews.llvm.org/D51255#1214427, @jdoerfert wrote:

> In https://reviews.llvm.org/D51255#1214424, @asl wrote:
>
> > I think we need to preserve the protocol. E.g. if the page is loaded via http we need to load css via http as well.
>
>
> That sounds reasonable and is (afaik) implied by removing the hostname.
>  As mentioned before, I like the solution but I just don't know if that might cause problems somewhere else.


Correct, removing the method and hostname "unmixes" the content so http loads stay http and https loads stay https.

My guess is that full URLs were used because the person doing so didn't have much experience hand coding web pages. Or maybe multiple web servers were used back then and have been consolidated since.

My guess is that at this point in history the software still in use has been updated to deal with both full and partial URLs. But I don't spend any time at all running llvm.org's infrastructure, so I can't sign off myself.


https://reviews.llvm.org/D51255





More information about the llvm-commits mailing list