[PATCH] D50935: Add data structure to form equivalence classes of mangled names.

[Andrei Elovikov via Phabricator via llvm-commits]

a.elovikov added inline comments.


================
Comment at: llvm/trunk/unittests/Support/ItaniumManglingCanonicalizerTest.cpp:19
+  FragmentKind Kind;
+  llvm::StringRef First;
+  llvm::StringRef Second;
----------------
Hi Richard,

We compile LLVM with the oldest supportable GCC version (4.8.5) and in that configuration this unittest fails with Seg. Fault.
For some reason GCC can't handle the `StringRef` inside these `std::initializer_list`s (i.e. changing `StringRef` to `const char *` in lines 19, 20 and 24 "fixes" the issue for me). It seems the issue was fixed somewhere in 4.9 timeline (4.9.4 works without any changes in the test).

But 4.8 is declared as supported in https://llvm.org/docs/GettingStarted.html#host-c-toolchain-both-compiler-and-standard-library so we need to do something with it. What would be your suggestion for that?


Repository:
  rL LLVM

https://reviews.llvm.org/D50935