[PATCH] D50917: [LLD] [COFF] Support MinGW automatic dllimport of data

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In https://reviews.llvm.org/D50917#1214042, @ruiu wrote:

> LGTM
>
> Thank you for doing this. It looks much less intrusive than I originally thought. Also, thank you for all your code comments. I believe it the new code is easy to understand.


Thanks for taking the time to review it! I was also initially pleasantly surprised by how easy it was to implement.



================
Comment at: COFF/Writer.cpp:1152
+void Writer::createRuntimePseudoRelocs() {
+  std::vector<RuntimePseudoReloc> RuntimePseudoRelocs;
+
----------------
ruiu wrote:
> Since the scope of this variable is much narrower than before, I'd use a  shorter name, such as Rels.
Oh, right, yes. Will change before committing.


https://reviews.llvm.org/D50917