[PATCH] D47179: [LLVM-C] Add Bindings For Named Metadata

[Robert Widmann via Phabricator via llvm-commits]

CodaFi updated this revision to Diff 162569.
CodaFi added a comment.

Spoke with @aprantl in person about this, and we came to the conclusion that named metadata nodes are different enough that the original TODO doesn't make any sense.  For one, it would mean that you could use named metadata nodes to create more kinds of cycles.  It would also mean the verifier would have to be extended to reject any usage of named metadata nodes as operand metadata.

Suffice to say, it's both simpler and more correct to make a new type in the C API and wrap to that.


https://reviews.llvm.org/D47179

Files:
  include/llvm-c/Core.h
  include/llvm-c/Types.h
  include/llvm/IR/Metadata.h
  lib/IR/Core.cpp
  test/Bindings/llvm-c/echo.ll
  tools/llvm-c-test/echo.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47179.162569.patch
Type: text/x-patch
Size: 9872 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180825/76022d45/attachment.bin>