[PATCH] D51228: [X86] Add FeatureCMOV explicitly to all CPUs that support it. Remove FeatureCMOV implication from Feature64Bit and FeatureSSE1

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 25 10:17:30 PDT 2018


craig.topper added a comment.

Clang doesn't seem to know about the cmov feature at all so I don't think there's anything needed there.



================
Comment at: lib/Target/X86/X86.td:912
 foreach P = ["athlon", "athlon-tbird"] in {
-  def : Proc<P, [FeatureX87, FeatureSlowUAMem16, Feature3DNowA,
+  def : Proc<P, [FeatureX87, FeatureSlowUAMem16, FeatureCMOV, Feature3DNowA,
                  FeatureNOPL, FeatureSlowSHLD]>;
----------------
RKSimon wrote:
> Is this an independent fix?
Looks like I may have gotten carried away with adding CMOV. Thanks.


https://reviews.llvm.org/D51228





More information about the llvm-commits mailing list