[PATCH] D51081: [DWARF v5] Refactoring range list dumping to fold DWARF v4 functionality into v5 handling (almost NFC).

[Victor Leschuk via Phabricator via llvm-commits]

vleschuk added inline comments.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFDebugRnglists.h:67
+  getAbsoluteRanges(llvm::Optional<BaseAddress> BaseAddr,
+                    uint16_t Version) const;
 };
----------------
wolfgangp wrote:
> vleschuk wrote:
> > I suggest that DWARFListType::extract() saves Version in class data, and thus we don't need to specify it here explicitly. Same suggestion regarding RangeListEntry and other classes.
> I was trying to avoid having to store the version in each list and entry, since it's always available from the context (i.e. the table during dumping and extracting). Based on David's suggestion I eliminated it from this function. It would remove a parameter from the extract and dump routines, however. I'm not sure. I guess I can see it stored in the list, but perhaps not in each individual entry.
Agree, I think every entry would be overkill.


https://reviews.llvm.org/D51081