[PATCH] D50433: A New Divergence Analysis for LLVM

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Analysis/SyncDependenceAnalysis.cpp:326-329
+        assert((defMap[exitBlock] != nullptr) &&
+               "no reaching def at loop exit");
+        if (defMap[exitBlock] != headerDefBlock) {
+          joinBlocks->insert(exitBlock);
----------------
simoll wrote:
> arsenm wrote:
> > Use .find() instead of [] twice?
> Are you sure? The first use in inside an assertion and won't affect non-asserting builds at all.
I find the side effecting properties of operator[] disgusting to the point I never use it


Repository:
  rL LLVM

https://reviews.llvm.org/D50433