[PATCH] D50894: Pull google/benchmark library to the LLVM tree

[Kirill Bobyrev via Phabricator via llvm-commits]

kbobyrev added inline comments.


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:1135
+  target_link_libraries(${benchmark_name} PRIVATE benchmark)
+  add_dependencies(Benchmarks ${benchmark_name})
+endfunction()
----------------
lebedev.ri wrote:
> Uppercase target name is unusual. Is there a precedent/reasoning for this?
Yes, there's *UnitTests* target.


https://reviews.llvm.org/D50894