[PATCH] D50894: Pull google/benchmark library to the LLVM tree

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In https://reviews.llvm.org/D50894#1212096, @kbobyrev wrote:

> In https://reviews.llvm.org/D50894#1212052, @lebedev.ri wrote:
>
> > Those cmake options still look wrong to me.
> >  It looks as-if you are trying to make these two options two three different things, with inconsistent mapping.
>
>
> Could you please rephrase? I'm not sure I get the last sentence.
>
> Also, sorry, I was is completely wrong. I added your description but both descriptions weren't what the proposed CMake variables do.
>
> `LLVM_INCLUDE_BENCHMARKS` doesn't execute them after the build, just like `LLVM_INCLUDE_TESTS` doesn't execute tests, it simply determines whether build targets would be generated or not (i.e. whether `benchmarks` and `unittests` will be added via `add_subdirectory`).


I'm confused because i do not understand what these two options are *meant* to do.
Is `LLVM_INCLUDE_BENCHMARKS` supposed to only control whether the //targets// to build the libbenchmark and the benchmark executables are generated or not?
Is `LLVM_BUILD_BENCHMARKS` supposed to control whether the targets that are added by `LLVM_INCLUDE_BENCHMARKS` are part of `all` build target?
If yes, then should `LLVM_BUILD_BENCHMARKS=on` imply `LLVM_INCLUDE_BENCHMARKS=on` ?
I'm confused because previously it was discussed that `LLVM_INCLUDE_BENCHMARKS` should control the **execution** of the built benchmarks themselves as part of the testing. (which i'm not sure will work)


https://reviews.llvm.org/D50894