[PATCH] D50894: Pull google/benchmark library to the LLVM tree

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/CMakeLists.txt:496-497
 
+option(LLVM_BUILD_BENCHMARKS "Build LLVM Benchmarks. If OFF, just generate build targets" OFF)
+option(LLVM_INCLUDE_BENCHMARKS "Generate build targets for the LLVM benchmarks." ON)
+
----------------
This looks weird. Is `LLVM_INCLUDE_BENCHMARKS=on`==`LLVM_BUILD_BENCHMARKS=off`?
Both of these talk about build targets. I suspect what you meant is 
```
option(LLVM_BUILD_BENCHMARKS "Build LLVM benchmarks. If OFF, just generate build targets" OFF)
option(LLVM_INCLUDE_BENCHMARKS "Execute LLVM benchmarks as part of tests. If OFF, just generate benchmarking targets" OFF)
```



https://reviews.llvm.org/D50894