[PATCH] D50925: [LICM] Hoist stores of invariant values to invariant addresses out of loops

[Philip Reames via Phabricator via llvm-commits]

reames marked an inline comment as done.
reames added a comment.

In https://reviews.llvm.org/D50925#1211383, @anna wrote:

> Added example:


(snipped example for length)

This is a really interesting example, but it's out of scope for this patch.  The critical bit in your example is not the store, it's the phi.  You're pointing out that when we have a diamond which exists only to select between two loop invariant values, we can do phi-to-select transform and then hoist the resulting select out of the loop.  I have some questions on your example, let's discuss offline.  This is definitely off topic for this review, so let's move further discussion of this one to a bug or another review thread if we get that far.


https://reviews.llvm.org/D50925