[PATCH] D49885: Thread safety analysis: Allow relockable scopes

[Aaron Ballman via llvm-commits]

On Wed, Aug 22, 2018 at 6:35 PM, Aaron Puchert via Phabricator
<reviews at reviews.llvm.org> wrote:
> aaronpuchert added inline comments.
>
>
> ================
> Comment at: lib/Analysis/ThreadSafety.cpp:932
> +      // We're relocking the underlying mutexes. Warn on double locking.
> +      if (FSet.findLock(FactMan, UnderCp))
> +        Handler.handleDoubleLock(DiagKind, UnderCp.toString(), entry.loc());
> ----------------
> delesley wrote:
>> Minor nit.  Use curly braces on the if, to match the else.
> Removing the braces [was suggested](https://reviews.llvm.org/D49885?id=157599#inline-439256) by @aaron.ballman in an earlier patch set, but I can just add them in again. I slightly favor having them, but I don't feel strongly either way.

My own opinions aren't strong here either, but I'm fine adding them
back in. We don't have clear guidance on what to do with braces for
if/else where one has braces and the other doesn't require them, but
I'm now starting to favor leaving the braces in rather than removing
them.

~Aaron

>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D49885
>
>
>