[PATCH] D50954: [NFC] Split logic of ImplicitControlFlowTracking to allow generalization

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 22 22:54:51 PDT 2018


fedor.sergeev accepted this revision.
fedor.sergeev added a comment.
This revision is now accepted and ready to land.

'Precedence' seems to be a rather overloaded term. "Instruction precedence" seems to be sufficiently close to "operator precedence", so I would select a different term here.
Say, "InstructionFlowTracking".

Otherwise, LGTM.



================
Comment at: include/llvm/Transforms/Utils/InstructionPrecedenceTracking.h:17
+// The class provides caching that allows to answer these queries quickly and
+// invalidate the cached data whenever the block's content has been changed.
+//===----------------------------------------------------------------------===//
----------------
This comment makes an impression that invalidation happens automatically.
Rephrase to something like "and to *manually* invalidate the cached data *after* the block's content has been changed". 


https://reviews.llvm.org/D50954





More information about the llvm-commits mailing list