[PATCH] D51113: [WebAssembly][NFC] Reorganize SIMD instructions

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 22 16:24:02 PDT 2018


aheejin added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:91
 }
+multiclass SIMDBinary<ValueType vec_t, string vec, SDNode node, string name,
+                      bits<32> simdop> {
----------------
It seems weird that we have SIMD instruction formats in its own file but other formats like integer/fp arithmetic still in `WebAssemblyInstrFormats.td`. Can you make a separate CL that pulls all those patterns, including SIMD ones, out of that file and puts into more relevant files, like, `WebAssemblyInstrInteger.td` for integer arithmetic and such?


Repository:
  rL LLVM

https://reviews.llvm.org/D51113





More information about the llvm-commits mailing list