[PATCH] D50277: [WebAssembly] Support for atomic fences

[Dan Gohman via Phabricator via llvm-commits]

sunfish added a comment.

In https://reviews.llvm.org/D50277#1210237, @aheejin wrote:

> We discussed how to implement fences here <https://github.com/WebAssembly/tool-conventions/issues/59>, and I think the general consensus was even though it may not be strictly necessary to emit `atomicrmw` for some cases, it can be user friendly and also might help support legacy builtins like `__sync_synchronize()`. And IMHO it is a single instruction anyway and fences are generally expected to be expensive, so no significant harm will be done. Does anyone have more concerns on this? If not, can we land this?


I have concerns which I expressed here: https://github.com/WebAssembly/tool-conventions/issues/59#issuecomment-413620669


Repository:
  rL LLVM

https://reviews.llvm.org/D50277