[PATCH] D51082: [WebAssembly] Arbitrary BUILD_VECTOR and remove i64x2.mul

[Thomas Lively via Phabricator via llvm-commits]

tlively marked 2 inline comments as done.
tlively added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:128
+  if (Subtarget->hasSIMD128() && EnableUnimplementedWasmSIMDInstrs)
+    setOperationAction(ISD::MUL, MVT::v2i64, Expand);
+
----------------
aheejin wrote:
> What happens if `hasSIMD128() == true` but not `EnableUnimplementedWasmSIMDInstrs`?
In that case v2i64 would not be a legal type, so type legalization would expand the op anyway. I suppose the same would happen if `hasSIMD128` were false as well, so this entire condition is unnecessary.


Repository:
  rL LLVM

https://reviews.llvm.org/D51082