[PATCH] D51128: [ORC] LLJITTest

Stefan Gränitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 22 14:44:48 PDT 2018


sgraenitz created this revision.
sgraenitz added a reviewer: lhames.
Herald added subscribers: llvm-commits, jfb, mgorny.

4 tests to illustrate the LLJIT API in combinations of sequential/concurrent and single/multi dylib.

With my other two changes applied this works reliably now:
https://reviews.llvm.org/D51126
https://reviews.llvm.org/D51127

I am using thread-local scope-exit guards to join worker threads back to their correct origins. This works surprisingly well!
It's definitely dangerous to do this with long-living threads, especially the main thread, as resources can get stuck there for long. OTOH it's quite simple compared to tracking the instances in containers that require locks etc...

What do you think?


Repository:
  rL LLVM

https://reviews.llvm.org/D51128

Files:
  unittests/ExecutionEngine/Orc/CMakeLists.txt
  unittests/ExecutionEngine/Orc/LLJITTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51128.162059.patch
Type: text/x-patch
Size: 8972 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180822/575dbbbf/attachment.bin>


More information about the llvm-commits mailing list