[PATCH] D51099: [GVN] Invalidate cached info for phis when setting dead predecessors to undef

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 22 11:35:07 PDT 2018


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Transforms/Scalar/GVN.cpp:2460
                              UndefValue::get(Phi.getType()));
+        if (MD && Phi.getType()->isPtrOrPtrVectorTy())
+          MD->invalidateCachedPointerInfo(&Phi);
----------------
The isPtrOrPtrVectorTy check is unnecessary; invalidateCachedPointerInfo does its own check.


Repository:
  rL LLVM

https://reviews.llvm.org/D51099





More information about the llvm-commits mailing list