[PATCH] D51052: [WIP] LLJITTest

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz added inline comments.


================
Comment at: unittests/ExecutionEngine/Orc/LLJITTest.cpp:161
         assert(Ms.size() < MaxMaterializerThreads &&
                "More slots used than preallocated");
 
----------------
sgraenitz wrote:
> The thread that runs `DispatchMaterialization` can't be blocked, right? So it must spawn a new thread, which must be joined back to this thread later. How do we know the correct one? Track it in `MaterializationUnit` and join in destructor? Also see my below comments.
> ~~Track it in MaterializationUnit and join in destructor?~~
The last shared ref to SMU below is in the newly spawned thread, so this won't work.


Repository:
  rL LLVM

https://reviews.llvm.org/D51052