[PATCH] D47541: Allow creating llvm::Function in non-zero address spaces

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 22 10:42:32 PDT 2018


bjope accepted this revision.
bjope added a comment.
This revision is now accepted and ready to land.

LGTM!

As mentioned earlier there still are some PointerType::getUnqual calls (mainly related to sanitizers and profiling?) that might need attention in the future. I don't see that as a stopper for this patch, specially since this shouldn't impact targets where function address space is zero (except that there will be an extra field for function address space in the bitcode). And I think it will be easier to do future fixes related to program address space when we have this basic framework in place.


Repository:
  rL LLVM

https://reviews.llvm.org/D47541





More information about the llvm-commits mailing list