[PATCH] D50629: AMDGPU: Fix getInstSizeInBytes

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUMCInstLower.cpp:308-314
+    // Sanity-check getInstSizeInBytes on explicitly specified CPUs (it cannot
+    // work correctly for the generic CPU).
+    //
+    // The isPseudo check really shouldn't be here, but unfortunately there are
+    // some negative lit tests that depend on being able to continue through
+    // here even when pseudo instructions haven't been lowered.
+    if (!MI->isPseudo() && STI.isCPUStringValid(STI.getCPU())) {
----------------
We don't actually have a generic CPU? We just pick a default?


Repository:
  rL LLVM

https://reviews.llvm.org/D50629