[PATCH] D51103: [Support] Add a way to run a function on a detached thread

[Zachary Turner via Phabricator via llvm-commits]

zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.

I'm almost wondering if we should just make a replacement for `std::thread` that allows to set the stack size in the constructor.  The approach here isn't wrong per se, but I think if we could just say `llvm::thread(Func, StackSize);` it would be useful in more places.



================
Comment at: lib/Support/Threading.cpp:109
+  SyncThreadInfo Info = {Fn, UserData};
+  llvm_execute_on_thread_impl(threadFuncSync, &Info, RequestedStackSize, false);
+}
----------------
Shouldn't the last parameter be set to `true` here?


Repository:
  rL LLVM

https://reviews.llvm.org/D51103