[PATCH] D51032: [ARM] Avoid injecting constant islands in movw+movt pairs on Windows

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 22 00:54:46 PDT 2018


mstorsjo updated this revision to Diff 161892.
mstorsjo edited the summary of this revision.
mstorsjo added a comment.

Applied @efriedma's suggestions, changed the testcase to a MIR test which only runs the arm-cp-islands pass on it, making the test much less fragile.

To make MIR work properly for thumb(2), I had to move metadata about the target flags from ARMInstrInfo to ARMBaseInstrInfo. I can commit that part in a separate commit if you prefer that.


https://reviews.llvm.org/D51032

Files:
  lib/Target/ARM/ARMBaseInstrInfo.cpp
  lib/Target/ARM/ARMBaseInstrInfo.h
  lib/Target/ARM/ARMConstantIslandPass.cpp
  lib/Target/ARM/ARMInstrInfo.cpp
  lib/Target/ARM/ARMInstrInfo.h
  test/CodeGen/ARM/constant-island-movwt.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51032.161892.patch
Type: text/x-patch
Size: 82531 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180822/b3d6ea95/attachment.bin>


More information about the llvm-commits mailing list