[PATCH] D51002: [Tooling] Allow -flto flags and filter out -Wa, flags

Stephen Hines via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 21 15:12:14 PDT 2018


srhines added inline comments.


================
Comment at: lib/Tooling/CompilationDatabase.cpp:304
     if (Cmd.getSource().getKind() == driver::Action::AssembleJobClass ||
+        Cmd.getSource().getKind() == driver::Action::BackendJobClass ||
         Cmd.getSource().getKind() == driver::Action::CompileJobClass) {
----------------
ioeric wrote:
> It seems to me that `BackendJob` will always be preceded by a `CompileJob` (according to https://github.com/llvm-mirror/clang/blob/master/lib/Driver/Driver.cpp#L3506), so at least of one job would be `CompileJobClass` here.  Not sure if I understood it correctly though. Would you mind clarify?
Is the difference here because clang driver != clang-tidy driver?


https://reviews.llvm.org/D51002





More information about the llvm-commits mailing list